git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] rebase: clarify --reschedule-failed-exec default

From
Illia Bobyr <illia.bobyr@gmail.com>
Date
Jan 5, 2024, 00:42 UTC
Message-ID
<20240105004246.1317445-2-illia.bobyr@gmail.com>
In-Reply-To
<20240105004246.1317445-1-illia.bobyr@gmail.com>
Documentation should mention the default behavior.

It is better to explain the persistent nature of the --reschedule-failed-exec flag from the user standpoint, rather than from the implementation standpoint.

Signed-off-by: Illia Bobyr <illia.bobyr@gmail.com>
---
 Documentation/git-rebase.txt | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)
diff --git Documentation/git-rebase.txt Documentation/git-rebase.txt
index 1dd65..45d3c 100644
--- Documentation/git-rebase.txt
+++ Documentation/git-rebase.txt
@@ -626,13 +626,16 @@ See also INCOMPATIBLE OPTIONS below.
 	Automatically reschedule `exec` commands that failed. This only makes
 	sense in interactive mode (or when an `--exec` option was provided).
 +
-Even though this option applies once a rebase is started, it's set for
-the whole rebase at the start based on either the
-`rebase.rescheduleFailedExec` configuration (see linkgit:git-config[1]
-or "CONFIGURATION" below) or whether this option is
-provided. Otherwise an explicit `--no-reschedule-failed-exec` at the
-start would be overridden by the presence of
-`rebase.rescheduleFailedExec=true` configuration.
+This option applies once a rebase is started. It is preserved for the whole
+rebase based on, in order, the command line option provided to the initial `git
+rebase`, the `rebase.rescheduleFailedExec` configuration (see
+linkgit:git-config[1] or "CONFIGURATION" below), or it defaults to false.
++
+Recording this option for the whole rebase is a convenience feature. Otherwise
+an explicit `--no-reschedule-failed-exec` at the start would be overridden by
+the presence of a `rebase.rescheduleFailedExec=true` configuration when `git
+rebase --continue` is invoked. Currently, you can not, pass
+`--[no-]reschedule-failed-exec` to `git rebase --continue`.
 
 --update-refs::
 --no-update-refs::
-- 
2.40.1
Previous: Illia BobyrNext: Illia Bobyr
Message 4 of 7 in “rebase: clarify --reschedule-failed-exec default”
  1. rebase: clarify --reschedule-failed-exec defaultIllia Bobyr, Jan 4, 2024
  2. Taylor BlauJan 4, 2024
  3. rebase: clarify --reschedule-failed-exec defaultIllia Bobyr, Jan 5, 2024
  4. rebase: clarify --reschedule-failed-exec defaultIllia Bobyr, Jan 5, 2024
  5. rebase: clarify --reschedule-failed-exec defaultIllia Bobyr, Jan 5, 2024
  6. rebase: clarify --reschedule-failed-exec defaultIllia Bobyr, Jan 5, 2024
  7. Taylor BlauJan 5, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.