Re: [PATCH v2 0/2] doc: bisect: change plural paths to singular pathspec

From: Taylor Blau <me@ttaylorr.com>
Date: Jan 3, 2024, 17:17 UTC
Message-ID: <ZZWWmXHa8ebtkZQ8@nand.local>
In-Reply-To: <6bcbd017-968e-4ac8-a56b-164b163c76d4@smtp-relay.sendinblue.com>

On Tue, Jan 02, 2024 at 07:02:05PM -0900, Britton Leo Kerin wrote:

Show 21 quoted lines

> Britton Leo Kerin (2):
>   doc: use singular form of repeatable path arg
>   doc: refer to pathspec instead of path
>
>  Documentation/git-bisect.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Range-diff against v1:
> 1:  90c081dcab ! 1:  da40e4736b doc: use singular form of repeatable path arg
>     @@ Commit message
>          later document text mentions 'path' arguments, while it doesn't mention
>          'paths'.
>
>     -    Signed-off-by: Britton L Kerin <britton.kergin@gmail.com>
>     +    Signed-off-by: Britton Leo Kerin <britton.kergin@gmail.com>
>
>       ## Documentation/git-bisect.txt ##
>      @@ Documentation/git-bisect.txt: The command takes various subcommands, and different options depending
> -:  ---------- > 2:  d932b6d501 doc: refer to pathspec instead of path
> --
> 2.43.0

Hmm. The end-state of these two patches looks good to me, but I probably would have written this change as a single change from "paths" -> "pathspec", not "paths" -> "path" -> "pathspec".

Thanks, Taylor