Re: [PATCH v4 00/17] bloom: changed-path Bloom filters v2 (& sundries)
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Oct 30, 2023, 20:24 UTC
- Message-ID
- <ZUARCJ1MmqgXfS4i@nand.local>
- In-Reply-To
- <20231023202212.GA5470@szeder.dev>
On Mon, Oct 23, 2023 at 10:22:12PM +0200, SZEDER Gábor wrote:
Show 12 quoted lines
> On Fri, Oct 20, 2023 at 01:27:00PM -0400, Taylor Blau wrote: > > I'm optimistic that with the amount of careful review that this topic > > has already received, that this round should do the trick. > > Unfortunately, I can't share this optimism. This series still lacks > tests exercising the interaction of different versions of Bloom > filters and split commit graphs, and the one such test that I sent a > while ago demonstrates that it's still broken. And it's getting > worse: back then I didn't send the related test that merged > commit-graph layers containing different Bloom filter versions, > because happened to succeed even back then; but, alas, with this > series even that test fails.
I am very confused here, the tests that you're referring to have been added to (and pass in) this series. What am I missing here?
Thanks, Taylor