Re: [PATCH v3 08/10] bulk-checkin: introduce `index_blob_bulk_checkin_incore()`

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 19, 2023, 15:30 UTC
Message-ID: <ZTFLrOpGaTQHEGcT@nand.local>
In-Reply-To: <xmqq34y7plj4.fsf@gitster.g>

On Wed, Oct 18, 2023 at 04:18:23PM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Taylor Blau <me@ttaylorr.com> writes:
>
> > Now that we have factored out many of the common routines necessary to
> > index a new object into a pack created by the bulk-checkin machinery, we
> > can introduce a variant of `index_blob_bulk_checkin()` that acts on
> > blobs whose contents we can fit in memory.
>
> Hmph.
>
> Doesn't the duplication between the main loop of the new
> deflate_obj_contents_to_pack() with existing deflate_blob_to_pack()
> bother you?

Yeah, I am not sure how I missed seeing the opportunity to clean that up. Another (hopefully final...) reroll incoming.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.