git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] doc/git-bisect: clarify `git bisect run` syntax

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 23, 2023, 07:38 UTC
Message-ID
<ZTYi55w_70ZlP8Ew@tanuki>
In-Reply-To
<xmqqa5sap44i.fsf@gitster.g>
On Sun, Oct 22, 2023 at 05:35:41PM -0700, Junio C Hamano wrote:
Show 38 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes:
> 
> > On Sun, Oct 22, 2023 at 4:03 PM cousteau via GitGitGadget
> > <gitgitgadget@gmail.com> wrote:
> >> The description of the `git bisect run` command syntax at the beginning
> >> of the manpage is `git bisect run <cmd>...`, which isn't quite clear
> >> about what `<cmd>` is or what the `...` mean; one could think that it is
> >> the whole (quoted) command line with all arguments in a single string,
> >> or that it supports multiple commands, or that it doesn't accept
> >> commands with arguments at all.
> >>
> >> Change to `git bisect run <cmd> [<arg>...]` to clarify the syntax.
> >
> > Okay, makes sense.
> >
> >> Signed-off-by: Javier Mora <cousteaulecommandant@gmail.com>
> >> ---
> >> diff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt
> >> @@ -26,7 +26,7 @@ on the subcommand:
> >> - git bisect run <cmd>...
> >> + git bisect run <cmd> [<arg>...]
> >
> > The output of `git bisect -h` suffers the same problem. Perhaps this
> > patch can fix that, as well?
> 
> Good eyes.
> 
> Not a new problem and obviously can be left outside of this simple
> update, but I wonder if we should eventually move these into the
> proper SYNOPSIS section.  Other multi-modal commands like "git
> checkout", "git rebase", etc. do list different forms all in the
> SYNOPSIS section.
> 
> I also thought at least some commands we know the "-h" output and
> SYNOPSIS match, we had tests to ensure they do not drift apart.  We
> would probably want to cover more subcommands with t0450.
> 
> Thanks.

If we don't want them to drift apart I wonder whether we could instead generate the synopsis from the output of `-h`? This reduces duplication at the cost of a more complex build process for our manpages.

Not saying that this is necessarily a good idea, just throwing it out there.

Patrick
Previous: Junio C HamanoNext: Javier Mora
Message 4 of 12 in “doc/git-bisect: clarify `git bisect run` syntax”
  1. doc/git-bisect: clarify `git bisect run` syntaxcousteau via GitGitGadget, Oct 22, 2023
  2. Eric SunshineOct 22, 2023
  3. Junio C HamanoOct 23, 2023
  4. Patrick SteinhardtOct 23, 2023
  5. Javier MoraOct 23, 2023
  6. Junio C HamanoOct 23, 2023
  7. Junio C HamanoOct 23, 2023
  8. doc/git-bisect: clarify `git bisect run` syntaxcousteau via GitGitGadget, Oct 23, 2023
  9. Eric SunshineOct 23, 2023
  10. Javier MoraOct 23, 2023
  11. Eric SunshineOct 23, 2023
  12. Junio C HamanoOct 24, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.