git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] doc/git-bisect: clarify `git bisect run` syntax

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Oct 23, 2023, 23:18 UTC
Message-ID
<CAPig+cS7-YrWf=cxbq6V8FH1BdtoqAS-EKzxF-ha-A0A6_91ew@mail.gmail.com>
In-Reply-To
<CAH1-q0hNSKgr1-dtZac=z7Bx15gON0Y-1pyBM57zuXaFPaJJKQ@mail.gmail.com>

On Mon, Oct 23, 2023 at 6:53 PM Javier Mora <cousteaulecommandant@gmail.com> wrote:

Show 7 quoted lines
> > the patch subject becomes a bit outdated with this addition.
>
> Right; I wanted to change it to something like "clarify `git bisect
> run` syntax and other minor changes" but wanted to keep the title
> concise.
> I guess I could change it to just "clarify `git bisect` syntax" though
> remove the "run").
Yup.
Show 14 quoted lines
> > the following two lines are already referencing placeholders
> > <term-new> and <term-old>
>
> That's why I added it; that `(bad|new|<term-new>)` felt a bit awkward
> with no previous explanation of what <term-new> was.
>
> > ...now we have an inconsistency again since this text just uses the
> > generic <term>. However, I haven't convinced myself that we need to
> > care about this inconsistency.
>
> I thought about that, but in THAT case it wasn't necessary because
> <term-new> and <term-old> are never used there (and I wanted to avoid
> making -h too long).  But it's true that it feels inconsistent; I may
> add it just for the sake of consistency.
I don't feel strongly about the inconsistency at this point.
Show 6 quoted lines
> Overall, maybe I should leave that change to a separate patch, even if
> it's a minor correction.  (This made more sense when I had in mind the
> plan to move everything from description to synopsis so I would need
> to touch all those lines anyway.)  The changes will be compatible
> anyway (they're far away enough to not cause merge conflicts).  What
> do you think?

I can certainly see the "{new,bad}" to "(new|bad") and <term> to <new-term>/<old-term> changes being separated out, making this a two- or three-patch series.

Previous: Javier MoraNext: Junio C Hamano
Message 11 of 12 in “doc/git-bisect: clarify `git bisect run` syntax”
  1. doc/git-bisect: clarify `git bisect run` syntaxcousteau via GitGitGadget, Oct 22, 2023
  2. Eric SunshineOct 22, 2023
  3. Junio C HamanoOct 23, 2023
  4. Patrick SteinhardtOct 23, 2023
  5. Javier MoraOct 23, 2023
  6. Junio C HamanoOct 23, 2023
  7. Junio C HamanoOct 23, 2023
  8. doc/git-bisect: clarify `git bisect run` syntaxcousteau via GitGitGadget, Oct 23, 2023
  9. Eric SunshineOct 23, 2023
  10. Javier MoraOct 23, 2023
  11. Eric SunshineOct 23, 2023
  12. Junio C HamanoOct 24, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.