Re: [PATCH 0/22] YAUPS: Yet Another Unused Parameter Series

From: Taylor Blau <me@ttaylorr.com>
Date: Aug 28, 2023, 23:35 UTC
Message-ID: <ZO0vQk6LWxNhLrd3@nand.local>
In-Reply-To: <20230828214604.GA3830831@coredump.intra.peff.net>

On Mon, Aug 28, 2023 at 05:46:04PM -0400, Jeff King wrote:

Show 7 quoted lines

> I'm back with another exciting installment of -Wunused-parameter warning
> fixes. Most of these are pretty boring and obvious; the first two are
> the most interesting in terms of rationale.
>
> I promise we're closing in on the finish line here. I only have about 20
> patches left after this, at which point we should be able to turn on the
> warning by default for developer builds.

Heh ;-). It's good to see us getting dangerously close to being able to turn on -Wunused-parameter in the DEVELOPER builds.

I reviewed this series, and all looked sensible. I left a couple notes throughout for potential further cleanups that we could do on top, which might be nice to squash in.

But I wouldn't be heartbroken if you want to ignore them, either. So with or without my suggestions, this series LGTM.

Thanks, Taylor