git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 05/22] worktree: mark unused parameters in each_ref_fn callback

From
Jeff King <peff@peff.net>
Date
Aug 28, 2023, 21:47 UTC
Message-ID
<20230828214736.GE3831137@coredump.intra.peff.net>
In-Reply-To
<20230828214604.GA3830831@coredump.intra.peff.net>

This is similar to the cases in 63e14ee2d6 (refs: mark unused each_ref_fn parameters, 2022-08-19), but it was added after that commit.

Signed-off-by: Jeff King <peff@peff.net>
---
 builtin/worktree.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/builtin/worktree.c b/builtin/worktree.c
index 10db70b7ec..62b7e26f4b 100644
--- a/builtin/worktree.c
+++ b/builtin/worktree.c
@@ -628,10 +628,10 @@ static void print_preparing_worktree_line(int detach,
  *
  * Returns 0 on failure and non-zero on success.
  */
-static int first_valid_ref(const char *refname,
-			   const struct object_id *oid,
-			   int flags,
-			   void *cb_data)
+static int first_valid_ref(const char *refname UNUSED,
+			   const struct object_id *oid UNUSED,
+			   int flags UNUSED,
+			   void *cb_data UNUSED)
 {
 	return 1;
 }
-- 
2.42.0.505.g4c6fb48dec
Previous: Jeff KingNext: Jeff King
Message 15 of 59 in “YAUPS: Yet Another Unused Parameter Series”
  1. 0/22 YAUPS: Yet Another Unused Parameter SeriesJeff King, Aug 28, 2023
  2. 01/22 sequencer: use repository parameter in short_commit_name()Jeff King, Aug 28, 2023
  3. Junio C HamanoAug 28, 2023
  4. Taylor BlauAug 28, 2023
  5. Jeff KingAug 29, 2023
  6. Junio C HamanoAug 29, 2023
  7. 02/22 sequencer: mark repository argument as unusedJeff King, Aug 28, 2023
  8. Taylor BlauAug 28, 2023
  9. Phillip WoodAug 29, 2023
  10. Jeff KingAug 29, 2023
  11. Phillip WoodAug 30, 2023
  12. 04/22 pack-bitmap: mark unused parameters in show_object callbackJeff King, Aug 28, 2023
  13. 03/22 ref-filter: mark unused parameters in parser callbacksJeff King, Aug 28, 2023
  14. 08/22 stash: mark unused parameter in diff callbackJeff King, Aug 28, 2023
  15. 05/22 worktree: mark unused parameters in each_ref_fn callbackJeff King, Aug 28, 2023
  16. 06/22 commit-graph: mark unused data parameters in generation callbacksJeff King, Aug 28, 2023
  17. Taylor BlauAug 28, 2023
  18. Jeff KingAug 29, 2023
  19. 07/22 ls-tree: mark unused parameter in callbackJeff King, Aug 28, 2023
  20. 09/22 trace2: mark unused us_elapsed_absolute parametersJeff King, Aug 28, 2023
  21. 11/22 test-trace2: mark unused argv/argc parametersJeff King, Aug 28, 2023
  22. 12/22 grep: mark unused parameter in output functionJeff King, Aug 28, 2023
  23. 14/22 negotiator/noop: mark unused callback parametersJeff King, Aug 28, 2023
  24. 10/22 trace2: mark unused config callback parameterJeff King, Aug 28, 2023
  25. 13/22 add-interactive: mark unused callback parametersJeff King, Aug 28, 2023
  26. 15/22 worktree: mark unused parameters in noop repair callbackJeff King, Aug 28, 2023
  27. 16/22 imap-send: mark unused parameters with NO_OPENSSLJeff King, Aug 28, 2023
  28. 17/22 grep: mark unused parmaeters in pcre fallbacksJeff King, Aug 28, 2023
  29. 18/22 credential: mark unused parameter in urlmatch callbackJeff King, Aug 28, 2023
  30. 19/22 fetch: mark unused parameter in ref_transaction callbackJeff King, Aug 28, 2023
  31. 20/22 bundle-uri: mark unused parameters in callbacksJeff King, Aug 28, 2023
  32. 22/22 update-ref: mark unused parameter in parser callbacksJeff King, Aug 28, 2023
  33. 21/22 gc: mark unused descriptors in scheduler callbacksJeff King, Aug 28, 2023
  34. Taylor BlauAug 28, 2023
  35. 0/22 Yet Another Unused Parameter SeriesJeff King, Aug 29, 2023
  36. 01/22 sequencer: use repository parameter in short_commit_name()Jeff King, Aug 29, 2023
  37. Phillip WoodAug 30, 2023
  38. 02/22 sequencer: mark repository argument as unusedJeff King, Aug 29, 2023
  39. 03/22 ref-filter: mark unused parameters in parser callbacksJeff King, Aug 29, 2023
  40. 04/22 pack-bitmap: mark unused parameters in show_object callbackJeff King, Aug 29, 2023
  41. 06/22 commit-graph: mark unused data parameters in generation callbacksJeff King, Aug 29, 2023
  42. 07/22 ls-tree: mark unused parameter in callbackJeff King, Aug 29, 2023
  43. 05/22 worktree: mark unused parameters in each_ref_fn callbackJeff King, Aug 29, 2023
  44. 08/22 stash: mark unused parameter in diff callbackJeff King, Aug 29, 2023
  45. 10/22 trace2: mark unused config callback parameterJeff King, Aug 29, 2023
  46. 09/22 trace2: mark unused us_elapsed_absolute parametersJeff King, Aug 29, 2023
  47. 11/22 test-trace2: mark unused argv/argc parametersJeff King, Aug 29, 2023
  48. 12/22 grep: mark unused parameter in output functionJeff King, Aug 29, 2023
  49. 13/22 add-interactive: mark unused callback parametersJeff King, Aug 29, 2023
  50. 14/22 negotiator/noop: mark unused callback parametersJeff King, Aug 29, 2023
  51. 15/22 worktree: mark unused parameters in noop repair callbackJeff King, Aug 29, 2023
  52. 16/22 imap-send: mark unused parameters with NO_OPENSSLJeff King, Aug 29, 2023
  53. 17/22 grep: mark unused parmaeters in pcre fallbacksJeff King, Aug 29, 2023
  54. 19/22 fetch: mark unused parameter in ref_transaction callbackJeff King, Aug 29, 2023
  55. 18/22 credential: mark unused parameter in urlmatch callbackJeff King, Aug 29, 2023
  56. 21/22 gc: mark unused descriptors in scheduler callbacksJeff King, Aug 29, 2023
  57. 20/22 bundle-uri: mark unused parameters in callbacksJeff King, Aug 29, 2023
  58. 22/22 update-ref: mark unused parameter in parser callbacksJeff King, Aug 29, 2023
  59. Junio C HamanoAug 30, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.