Re: [PATCH] t9001: fix/unify indentation regarding pipes somewhat

From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Date: Aug 10, 2023, 10:26 UTC
Message-ID: <ZNS7PJ0oyOQLeaZ7@ugly>
In-Reply-To: <xmqq350sm21v.fsf@gitster.g>

On Wed, Aug 09, 2023 at 12:46:36PM -0700, Junio C Hamano wrote:

Show 11 quoted lines

>Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
>> -	grep "=?UTF-8?q?=C3=A0=C3=A9=C3=AC=C3=B6=C3=BA?= <utf8@example.com>"
>> +		grep "=?UTF-8?q?=C3=A0=C3=A9=C3=AC=C3=B6=C3=BA?= <utf8@example.com>"
>
>... I do not think we want this.  A long pipeline should be written
>without extra indentation like
>
>	A |
>		B |
>			C
>

... which is not how i would do it.

Show 6 quoted lines

>but more like
>
>	A |
>	B |
>	C
>

i'd argue that this should be written as

	A |
		B |
		C

like other continued lines (no trailing backslashes are needed here, but it would be ok to add them, and there is in fact a commit that does just that in other places, and one might do the same here in a followup).

regards