git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] t9001: fix indentation in test_no_confirm()

From
Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Date
Aug 13, 2023, 10:46 UTC
Message-ID
<20230813104649.2919412-1-oswald.buddenhagen@gmx.de>
In-Reply-To
<xmqq350sm21v.fsf@gitster.g>

The continuations of the compound command were indented as if they were continuations of the embedded pipe, which was misleading.

Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
---
v2:
- reduced to what seems to be welcome.
  fwiw, this is actually v0.
Cc: Junio C Hamano <gitster@pobox.com>
---
 t/t9001-send-email.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 48bf0af2ee..542f524f04 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -61,8 +61,8 @@ test_no_confirm () {
 		--smtp-server="$(pwd)/fake.sendmail" \
 		$@ \
 		$patches >stdout &&
-		! grep "Send this email" stdout &&
-		>no_confirm_okay
+	! grep "Send this email" stdout &&
+	>no_confirm_okay
 }
 
 # Exit immediately to prevent hang if a no-confirm test fails
-- 
2.40.0.152.g15d061e6df
Previous: Oswald Buddenhagen
Message 6 of 6 in “t9001: fix/unify indentation regarding pipes somewhat”
  1. t9001: fix/unify indentation regarding pipes somewhatOswald Buddenhagen, Aug 9, 2023
  2. Junio C HamanoAug 9, 2023
  3. Oswald BuddenhagenAug 10, 2023
  4. Junio C HamanoAug 10, 2023
  5. Oswald BuddenhagenAug 13, 2023
  6. t9001: fix indentation in test_no_confirm()Oswald Buddenhagen, Aug 13, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.