git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] revision: refactor ref_excludes to ref_visibility

From
Taylor Blau <me@ttaylorr.com>
Date
Jun 22, 2023, 12:53 UTC
Message-ID
<ZJREYU0daKlmfjhr@nand.local>
In-Reply-To
<ZJRDZ7NhyNpTV8jD@nand.local>
On Thu, Jun 22, 2023 at 08:49:43AM -0400, Taylor Blau wrote:
Show 9 quoted lines
> I am left wondering: why doesn't the rule pertaining to
> refs/heads/foo/baz show up in the included list? Likewise, what happens
> with refs/heads/bar/baz/quux? It is a child of an excluded rule, so the
> question is which list takes priority.
>
> Mostly, I am wondering if I am missing something that would explain why
> you couldn't modify the above example's excluded list to contain
> something like "!refs/heads/bar/baz/quux", eliminating the need for the
> include list entirely.

Another potential quirk that I just now thought of: what are the rules for what can go in the include list? Fully qualified references only? Or can we have patterns (e.g. refs/foo/bar/*). Presumably you'd want to have the namespace-stripping operator ^, but not !, since negating an include rule seems to imply that it should be in the exclude list.

Thanks, Taylor

Previous: Taylor BlauNext: Taylor Blau
Message 10 of 13 in “revision: refactor ref_excludes to ref_visibility”
  1. 0/3 revision: refactor ref_excludes to ref_visibilityJohn Cai via GitGitGadget, Jun 21, 2023
  2. 2/3 revision: add ref_visible() helperJohn Cai via GitGitGadget, Jun 21, 2023
  3. 1/3 revision: rename ref_excludes to ref_visibilityJohn Cai via GitGitGadget, Jun 21, 2023
  4. Taylor BlauJun 22, 2023
  5. 3/3 pack-refs: use new ref_visible() helperJohn Cai via GitGitGadget, Jun 21, 2023
  6. Junio C HamanoJun 21, 2023
  7. Taylor BlauJun 22, 2023
  8. Taylor BlauJun 22, 2023
  9. Taylor BlauJun 22, 2023
  10. Taylor BlauJun 22, 2023
  11. Taylor BlauJun 22, 2023
  12. John CaiJun 23, 2023
  13. Junio C HamanoJun 23, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.