Re: [PATCH 0/3] revision: refactor ref_excludes to ref_visibility

From: Taylor Blau <me@ttaylorr.com>
Date: Jun 22, 2023, 12:52 UTC
Message-ID: <ZJREB4p4RA0T5cO2@nand.local>
In-Reply-To: <xmqqy1kcfsb6.fsf@gitster.g>

On Wed, Jun 21, 2023 at 01:56:13PM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> "John Cai via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > The ref_excludes API is used to tell which refs should be excluded. However,
> > there are times when we would want to add refs to explicitly include as
> > well. 4fe42f326e (pack-refs: teach pack-refs --include option, 2023-05-12)
> > taught pack-refs how to include certain refs, but did it in a more manual
> > way by keeping the ref patterns in a separate string list. Instead, we can
> > easily extend the ref_excludes API to include refs as well, since this use
> > case fits into the API nicely.
>
> Hmph, how would this interact with the other topic in flight that
> touch the ref exclusion logic tb/refs-exclusion-and-packed-refs?

Good question. Besides trivial conflicts from John's patches to rename this API, I think the sensible thing to do with my tb/refs-exclusion-and-packed-refs topic would be to also refuse to use the jump list if there are any non-trivial exclusion *or* inclusion entries.

But I have some more general concerns about the approach taken by this topic, namely that I do not understand a reference "foo" cannot be included by adding a "!foo" entry to the excluded list.

Thanks, Taylor