Re: Draft of Git Rev News edition 99

From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: May 30, 2023, 01:10 UTC
Message-ID: <ZHVM6dw4lIHjdLGw@debian.me>
In-Reply-To: <CAP8UFD2zaEPKNj2SpgGQUyFRmNp24E-8n1O9K5Se9=OhXckxGQ@mail.gmail.com>

On Tue, May 30, 2023 at 12:34:17AM +0200, Christian Couder wrote:

Show 7 quoted lines

> Everyone is welcome to contribute in any section either by editing the
> above page on GitHub and sending a pull request, or by commenting on
> this GitHub issue:
> 
>   https://github.com/git/git.github.io/issues/643
> 
> You can also reply to this email.

From the draft:

Show 5 quoted lines

> After some discussions between Peff, Phillip and Junio, Peff sent a version 3
> of his patch series with small changes. Especially the new version makes sure
> we reject timestamps that start with a character that we don't consider a
> whitespace or a digit or the - character before using strtoumax(3) as this was
> considered enough to avoid issues related to this function.

I think it's odd to have second person (we) when the text is written in third-person perspective. Thus, abouve should have been:

> ... Especially in the new version, it made sure that timestamps that were
> started with a character that wasn't considered as either a whitespace, a
> digit, or - character, were rejected before using strtoumax(3) ...

Thanks.

-- 
An old man doll... just what I always wanted! - Clara