Re: Draft of Git Rev News edition 99

From: Christian Couder <christian.couder@gmail.com>
Date: Jun 2, 2023, 10:19 UTC
Message-ID: <CAP8UFD3OptAe-98+Q=WJZkhPnNVY91N9+Mx5thZoa3ieOXShrg@mail.gmail.com>
In-Reply-To: <ZHVM6dw4lIHjdLGw@debian.me>

Hi Bagas,

On Tue, May 30, 2023 at 3:17 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:

Show 7 quoted lines

> > After some discussions between Peff, Phillip and Junio, Peff sent a version 3
> > of his patch series with small changes. Especially the new version makes sure
> > we reject timestamps that start with a character that we don't consider a
> > whitespace or a digit or the - character before using strtoumax(3) as this was
> > considered enough to avoid issues related to this function.
>
> I think it's odd to have second person (we) when the text is written in

I think "we" is the first person.

Show 7 quoted lines

> third-person perspective. Thus, abouve should have been:
>
> > ... Especially in the new version, it made sure that timestamps that were
> > started with a character that wasn't considered as either a whitespace, a
> > digit, or - character, were rejected before using strtoumax(3) ...
>
> Thanks.

Thanks for your suggestion and sorry for forgetting to take it into account.

I must say that I think it's Ok to use "we" instead of "the Git community" in Git Rev News. I think we have often taken this perspective before.

By the way, does someone knows why the announce of edition 99 doesn't seem to have appeared yet on https://lore.kernel.org/git/ :

https://lore.kernel.org/git/?q=s%3A%22Git+Rev+News+edition+99%22

while it appeared on https://public-inbox.org/git/ :

https://public-inbox.org/git/CAP8UFD2MNFjEjrGVyj__d4f95nC=D7csKajYzdtMFkfXKmrixQ@mail.gmail.com/

Thanks!