Re: [PATCH 0/3] dropping "verbose" test helper function
- From
Taylor Blau <me@ttaylorr.com>
- Date
- May 8, 2023, 22:26 UTC
- Message-ID
- <ZFl3FSt2a59G/X7m@nand.local>
- In-Reply-To
- <20230508185953.GA2108869@coredump.intra.peff.net>
On Mon, May 08, 2023 at 02:59:53PM -0400, Jeff King wrote:
Show 13 quoted lines
> I happened across an instance of the "verbose" helper function in a > test recently. I think it's clear we prefer the "-x" tracing to it these > days, and we've been slowly removing instances. This series gets rid of > the last few. > > The actual change (and rationale) is in patch 3. Patch 1 just fixes pipe > problems on lines we'll be touching patch 3, and patch 2 is a cute > optimization enabled by patch 1. I don't think any of it should be very > controversial, but it can all be split up if need be. > > [1/3]: t7001: avoid git on upstream of pipe > [2/3]: t7001: use "ls-files --format" instead of "cut" > [3/3]: t: drop "verbose" helper function
All look good to me, I'd be happy to see this get picked up.
Thanks, Taylor