git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] dropping "verbose" test helper function

From
Jeff King <peff@peff.net>
Date
May 8, 2023, 18:59 UTC
Message-ID
<20230508185953.GA2108869@coredump.intra.peff.net>

I happened across an instance of the "verbose" helper function in a test recently. I think it's clear we prefer the "-x" tracing to it these days, and we've been slowly removing instances. This series gets rid of the last few.

The actual change (and rationale) is in patch 3. Patch 1 just fixes pipe problems on lines we'll be touching patch 3, and patch 2 is a cute optimization enabled by patch 1. I don't think any of it should be very controversial, but it can all be split up if need be.

  [1/3]: t7001: avoid git on upstream of pipe
  [2/3]: t7001: use "ls-files --format" instead of "cut"
  [3/3]: t: drop "verbose" helper function
 t/t0020-crlf.sh            | 38 +++++++++++++++++++-------------------
 t/t1301-shared-repo.sh     |  4 ++--
 t/t3427-rebase-subtree.sh  | 12 ++++++------
 t/t4022-diff-rewrite.sh    |  2 +-
 t/t4062-diff-pickaxe.sh    |  2 +-
 t/t5304-prune.sh           | 16 ++++++++--------
 t/t6006-rev-list-format.sh |  2 +-
 t/t6501-freshen-objects.sh |  2 +-
 t/t7001-mv.sh              | 37 +++++++++++++++++++++----------------
 t/t7300-clean.sh           |  4 ++--
 t/t9902-completion.sh      | 30 +++++++++++++++---------------
 t/test-lib-functions.sh    |  9 ---------
 12 files changed, 77 insertions(+), 81 deletions(-)
-Peff
Next: Jeff King
Message 1 of 6 in “dropping "verbose" test helper function”
  1. 0/3 dropping "verbose" test helper functionJeff King, May 8, 2023
  2. 1/3 t7001: avoid git on upstream of pipeJeff King, May 8, 2023
  3. 2/3 t7001: use "ls-files --format" instead of "cut"Jeff King, May 8, 2023
  4. 3/3 t: drop "verbose" helper functionJeff King, May 8, 2023
  5. Taylor BlauMay 8, 2023
  6. Taylor BlauMay 8, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.