git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] global: resolve Perl executable via PATH

From
Patrick Steinhardt <ps@pks.im>
Date
Apr 6, 2023, 08:07 UTC
Message-ID
<ZC59sbedolRAWF9k@ncase>
In-Reply-To
<20230405181505.GA517608@coredump.intra.peff.net>
On Wed, Apr 05, 2023 at 02:15:05PM -0400, Jeff King wrote:
Show 24 quoted lines
> On Wed, Apr 05, 2023 at 07:32:22PM +0200, Patrick Steinhardt wrote:
> 
> > Yeah, agreed, the scripts we install are fine from all I can tell. I
> > should've clarified, but what I care about is our build infra as well as
> > our test scripts. That's neither clear from the commit description nor
> > from the changes that I'm doing.
> 
> Ah, OK, that makes more sense.
> 
> > I'd be happy to keep the current state of installed scripts as-is and
> > resend another iteration of this patch that only addresses shebangs used
> > in internal scripts.
> 
> We generally try to use $PERL_PATH even for building and testing by
> invoking "$PERL_PATH script.pl", and declaring a perl() wrapper within
> the test scripts. But I would not be surprised if there are cases where
> we fail to (and nobody noticed because it usually just works to find one
> at /usr/bin/perl).
> 
> IMHO we should aim for fixing those inconsistencies, and then letting
> people set PERL_PATH as appropriate (even to something that will find it
> via $PATH if they want to).
> 
> -Peff

Makes sense to me, I'll send a v2 that goes into this direction. Thanks all for your input!

Patrick
Previous: Felipe ContrerasNext: Kristoffer Haugsbakk
Message 18 of 27 in “global: resolve Perl executable via PATH”
  1. global: resolve Perl executable via PATHPatrick Steinhardt, Apr 5, 2023
  2. Felipe ContrerasApr 5, 2023
  3. Patrick SteinhardtApr 5, 2023
  4. Todd ZullingerApr 5, 2023
  5. Patrick SteinhardtApr 5, 2023
  6. Todd ZullingerApr 5, 2023
  7. Felipe ContrerasApr 5, 2023
  8. Patrick SteinhardtApr 5, 2023
  9. Junio C HamanoApr 5, 2023
  10. Felipe ContrerasApr 6, 2023
  11. Jeff KingApr 5, 2023
  12. Patrick SteinhardtApr 5, 2023
  13. Jeff KingApr 5, 2023
  14. Felipe ContrerasApr 6, 2023
  15. Jeff KingApr 6, 2023
  16. Ævar Arnfjörð BjarmasonApr 6, 2023
  17. Felipe ContrerasApr 18, 2023
  18. Patrick SteinhardtApr 6, 2023
  19. Kristoffer HaugsbakkApr 5, 2023
  20. Eric WongApr 5, 2023
  21. Felipe ContrerasApr 6, 2023
  22. Ævar Arnfjörð BjarmasonApr 6, 2023
  23. Jeff KingApr 6, 2023
  24. Patrick SteinhardtApr 6, 2023
  25. t/lib-httpd: pass PERL_PATH to CGI scriptsJeff King, Apr 6, 2023
  26. Junio C HamanoApr 6, 2023
  27. Felipe ContrerasApr 18, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.