Re: [PATCH] t/lib-httpd: pass PERL_PATH to CGI scripts

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 18, 2023, 09:04 UTC
Message-ID: <643e5d1a3db93_21c95429444@chronos.notmuch>
In-Reply-To: <20230406093602.GD2215039@coredump.intra.peff.net>

Jeff King wrote:

Show 11 quoted lines

> On Thu, Apr 06, 2023 at 10:19:03AM +0200, Patrick Steinhardt wrote:
> 
> > > Does this fix the cases you saw, or are there others?
> > 
> > You know, let's just go with your patch. With PERL_PATH set it fixes all
> > the issues I have observed. At some point in time I saw more issues than
> > the one you fix here, but that's because my `config.mak` got lost
> > without me noticing. Oops, embarassing.
> 
> OK, that is good if there is nothing left to fix. :) Let us know if any
> of the others pop up again.

For the record: I applied both patches and I can attest that Jeff's patch fixes all the problems, rendering Patrick's patch unnecessary.

However, in my opinion Patrick's patch is still desirable and should be applied, even though after Jeff's patch it doesn't fix anything.

It's just a good practice.

Cheers.

-- 
Felipe Contreras