git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/2] Fix Meson Perl version check

From
Patrick Steinhardt <ps@pks.im>
Date
Feb 19, 2025, 07:17 UTC
Message-ID
<Z7WFpu6QEBJXwAIH@pks.im>
In-Reply-To
<xmqq8qq3kqyk.fsf@gitster.g>
On Tue, Feb 18, 2025 at 11:12:03AM -0800, Junio C Hamano wrote:
Show 16 quoted lines
> Peter Oliver <p.d.oliver@mavit.org.uk> writes:
> 
> > Suggested comments added.
> >
> > Peter Oliver (2):
> >   meson: bump minimum required Perl version to 5.26.0
> >   meson: fix Perl version check for Meson versions before 1.7.0
> >
> >  meson.build | 17 ++++++++++++++++-
> >  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> I wasn't involved in the review of the previous rounds (so it was a
> bit of surprise for me to be listed on the To: line), but it seems
> that Patrick and you polished these two together, so I'll see if I
> can add Patrick's acked-by/reviewed-by while queuing by waiting for
> the earth to turn one rotation.

Yup, this version looks good to me, thanks Peter. So please feel free to add either my Acked-by or Reviewed-by, I'd be fine with either.

Patrick
Previous: Junio C HamanoNext: Junio C Hamano
Message 13 of 16 in “Check for Perl 5.26.0 from Meson build”
  1. 1/2 Check for Perl 5.26.0 from Meson buildPeter Oliver, Jan 20, 2025
  2. 2/2 Fix Meson Perl version checkPeter Oliver, Jan 20, 2025
  3. Patrick SteinhardtJan 21, 2025
  4. Patrick SteinhardtJan 21, 2025
  5. 0/2 Fix Meson Perl version checkPeter Oliver, Jan 24, 2025
  6. 1/2 meson: bump minimum required Perl version to 5.26.0Peter Oliver, Jan 24, 2025
  7. 2/2 meson: fix Perl version check for Meson versions before 1.7.0Peter Oliver, Jan 24, 2025
  8. Patrick SteinhardtJan 27, 2025
  9. 0/2 Fix Meson Perl version checkPeter Oliver, Feb 18, 2025
  10. 1/2 meson: bump minimum required Perl version to 5.26.0Peter Oliver, Feb 18, 2025
  11. 2/2 meson: fix Perl version check for Meson versions before 1.7.0Peter Oliver, Feb 18, 2025
  12. Junio C HamanoFeb 18, 2025
  13. Patrick SteinhardtFeb 19, 2025
  14. Junio C HamanoFeb 19, 2025
  15. Peter OliverFeb 25, 2025
  16. Junio C HamanoFeb 25, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.