git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/2] meson: fix Perl version check for Meson versions before 1.7.0

From
POPeter Oliver <p.d.oliver@mavit.org.uk>
Date
Jan 24, 2025, 16:30 UTC
Message-ID
<20250124163049.23965-3-git@mavit.org.uk>
In-Reply-To
<20250124163049.23965-1-git@mavit.org.uk>

Command `perl --version` says, e.g., “This is perl 5, version 26, subversion 0 (v5.26.0)”, which older versions of Meson interpret as version 26.

This will be fixed in Meson 1.7.0, but at the time of writing that isn’t yet released.

If we run `perl -V:version` we get the unambiguous response “version='5.26.0';”, but we need at least Meson 1.5.0 to be able to do that.

Signed-off-by: Peter Oliver <git@mavit.org.uk>
---
 meson.build | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index f01d81b39f..80af578d36 100644
--- a/meson.build
+++ b/meson.build
@@ -755,7 +755,11 @@ endif
 
 # Note that we only set NO_PERL if the Perl features were disabled by the user.
 # It may not be set when we have found Perl, but only use it to run tests.
-perl = find_program('perl', version: '>=5.26.0', dirs: program_path, required: perl_required)
+if meson.version().version_compare('>=1.5.0')
+  perl = find_program('perl', dirs: program_path, required: perl_required, version: '>=5.26.0', version_argument: '-V:version')
+else
+  perl = find_program('perl', dirs: program_path, required: perl_required, version: '>=26')
+endif
 perl_features_enabled = perl.found() and get_option('perl').allowed()
 if perl_features_enabled
   build_options_config.set('NO_PERL', '')
-- 
2.48.1
Previous: Peter OliverNext: Patrick Steinhardt
Message 7 of 16 in “Check for Perl 5.26.0 from Meson build”
  1. 1/2 Check for Perl 5.26.0 from Meson buildPeter Oliver, Jan 20, 2025
  2. 2/2 Fix Meson Perl version checkPeter Oliver, Jan 20, 2025
  3. Patrick SteinhardtJan 21, 2025
  4. Patrick SteinhardtJan 21, 2025
  5. 0/2 Fix Meson Perl version checkPeter Oliver, Jan 24, 2025
  6. 1/2 meson: bump minimum required Perl version to 5.26.0Peter Oliver, Jan 24, 2025
  7. 2/2 meson: fix Perl version check for Meson versions before 1.7.0Peter Oliver, Jan 24, 2025
  8. Patrick SteinhardtJan 27, 2025
  9. 0/2 Fix Meson Perl version checkPeter Oliver, Feb 18, 2025
  10. 1/2 meson: bump minimum required Perl version to 5.26.0Peter Oliver, Feb 18, 2025
  11. 2/2 meson: fix Perl version check for Meson versions before 1.7.0Peter Oliver, Feb 18, 2025
  12. Junio C HamanoFeb 18, 2025
  13. Patrick SteinhardtFeb 19, 2025
  14. Junio C HamanoFeb 19, 2025
  15. Peter OliverFeb 25, 2025
  16. Junio C HamanoFeb 25, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.