Re: [PATCH 04/10] github: convert all Linux jobs to be containerized
On Fri, Jan 03, 2025 at 02:06:59PM -0500, Jeff King wrote:
Show 31 quoted lines
> On Fri, Jan 03, 2025 at 01:56:40PM -0500, Jeff King wrote:
>
> > I do wonder if it will affect run times. Presumably GitHub has made it
> > pretty fast to get things started on the bare runner image. Now we're
> > pulling docker images. That is hopefully pretty optimized and cached,
> > but it is extra work. Might be worth measuring.
>
> Just peeking at your CI run here:
>
> https://github.com/git/git/actions/runs/12597967146
>
> versus the latest run on Junio's master:
>
> https://github.com/git/git/actions/runs/12589300693
>
> I see:
>
> job | old | new
> --------------------|------|------
> linux-TEST-vars 11m30s 10m54s
> linux-asan-ubsan 30m26s 31m14s
> linux-gcc 9m47s 10m6s
> linux-gcc-default 9m47s 9m41s
> linux-leaks 25m50s 25m21s
> linux-meson 10m36s 10m41s
> linux-reftable 10m25s 10m23s
> linux-reftable-leaks 27m18s 27m28s
> linux-sha256 9m54s 10m31s
>
> So it looks like any change is lost in the noise (sha256 is noticeably
> slower, but most jobs aren't, and some are even faster).
Thanks for verifying my claims!
Patrick