Re: [PATCH v2 0/4] reftable: fix realloc error handling

From: Patrick Steinhardt <ps@pks.im>
Date: Dec 30, 2024, 07:25 UTC
Message-ID: <Z3JK4lW4REYqBK9I@pks.im>
In-Reply-To: <f4677194-0a3a-4f07-b003-c0295b51c100@web.de>

On Sat, Dec 28, 2024 at 10:43:41AM +0100, René Scharfe wrote:

Show 9 quoted lines

> Changes since v1:
> - added unit tests
> - explicitly set pointer to NULL on REFTABLE_ALLOC_GROW_OR_NULL failure
>   in patch 2; omission found by unit test
> 
>   reftable: avoid leaks on realloc error
>   reftable: fix allocation count on realloc error
>   reftable: handle realloc error in parse_names()
>   t-reftable-merged: handle realloc errors

I think this version is good enough for now. I'm not particularly happy about the split we have with the reftable reallocators now, but don't think that the series really is to blame for that as it simply fixes a preexisting issue. We can iterate on this in the future.

Thanks!

Patrick