Re: [PATCH 0/4] reftable: fix realloc error handling

From: Patrick Steinhardt <ps@pks.im>
Date: Dec 27, 2024, 10:34 UTC
Message-ID: <Z26CnRsw0yqQblMO@pks.im>
In-Reply-To: <2b9fba8d-be63-4145-9d25-a2151e422cfa@web.de>

On Wed, Dec 25, 2024 at 07:33:07PM +0100, René Scharfe wrote:

Show 8 quoted lines

> The current handling of reallocation errors leaks the original
> allocation in most cases and corrupts the capacity variable.  Fix
> that in REFTABLE_ALLOC_GROW and by providing a new macro
> REFTABLE_ALLOC_GROW_OR_NULL -- solve this somewhat tricky issue
> centrally, with minimal impact to calling code.
> 
> And the last two patches add error handling to the remaining
> places that still lack it.

Thanks a lot for working on this!

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.