Re: [PATCH v3 6/7] git-submodule.sh: improve variables readability
- From
Đoàn Trần Công Danh <congdanhqx@gmail.com>
- Date
- Dec 11, 2024, 01:56 UTC
- Message-ID
- <Z1jxSJKl8nwGbYa5@danh.dev>
- In-Reply-To
- <20241210184442.10723-7-royeldar0@gmail.com>
On 2024-12-10 20:44:41+0200, Roy Eldar <royeldar0@gmail.com> wrote:
Show 10 quoted lines
> ;;
> --reference)
> case "$2" in '') usage ;; esac
> - reference_path=$2
> + reference="--reference=$2"
> shift
> ;;
> --reference=*)
> - reference_path="${1#--reference=}"
> + reference="$1"--reference takes a path to some repository, (see also git-clone --reference), thus it can have any characters, including but not limit to whitespace. I think we need to discard this hunk!
-- Danh