git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 3/8] git-submodule.sh: improve parsing of short options

From
RERoy Eldar <royeldar0@gmail.com>
Date
Dec 9, 2024, 16:50 UTC
Message-ID
<20241209165009.40653-4-royeldar0@gmail.com>
In-Reply-To
<20241209165009.40653-1-royeldar0@gmail.com>

Some command-line options have a short form which takes an argument; for example, "--jobs" has the form "-j", and it takes a numerical argument.

When parsing short options, support the case where there is no space between the flag and the option argument, in order to improve consistency with the rest of the builtin git commands.

Signed-off-by: Roy Eldar <royeldar0@gmail.com>
---
 git-submodule.sh | 13 +++++++++++++
 1 file changed, 13 insertions(+)
diff --git a/git-submodule.sh b/git-submodule.sh
index a47d2a89f3..fc85458fb1 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -77,6 +77,9 @@ cmd_add()
 			branch=$2
 			shift
 			;;
+		-b*)
+			branch="${1#-b}"
+			;;
 		--branch=*)
 			branch="${1#--branch=}"
 			;;
@@ -352,6 +355,9 @@ cmd_update()
 			jobs="--jobs=$2"
 			shift
 			;;
+		-j*)
+			jobs="--jobs=${1#-j}"
+			;;
 		--jobs=*)
 			jobs=$1
 			;;
@@ -431,6 +437,9 @@ cmd_set_branch() {
 			branch=$2
 			shift
 			;;
+		-b*)
+			branch="${1#-b}"
+			;;
 		--branch=*)
 			branch="${1#--branch=}"
 			;;
@@ -519,6 +528,10 @@ cmd_summary() {
 			isnumber "$summary_limit" || usage
 			shift
 			;;
+		-n*)
+			summary_limit="${1#-n}"
+			isnumber "$summary_limit" || usage
+			;;
 		--summary-limit=*)
 			summary_limit="${1#--summary-limit=}"
 			isnumber "$summary_limit" || usage
-- 
2.30.2
Previous: Roy EldarNext: Roy Eldar
Message 12 of 43 in “git-submodule.sh: improve parsing of options”
  1. 0/3 git-submodule.sh: improve parsing of optionsRoy Eldar, Dec 7, 2024
  2. 1/3 git-submodule.sh: make some variables booleanRoy Eldar, Dec 7, 2024
  3. Junio C HamanoDec 7, 2024
  4. Eric SunshineDec 8, 2024
  5. 2/3 git-submodule.sh: improve parsing of some long optionsRoy Eldar, Dec 7, 2024
  6. 3/3 git-submodule.sh: improve parsing of short optionsRoy Eldar, Dec 7, 2024
  7. Junio C HamanoDec 8, 2024
  8. Roy EDec 9, 2024
  9. 0/8 git-submodule.sh: improve parsing of optionsRoy Eldar, Dec 9, 2024
  10. 1/8 git-submodule.sh: make some variables booleanRoy Eldar, Dec 9, 2024
  11. 2/8 git-submodule.sh: improve parsing of some long optionsRoy Eldar, Dec 9, 2024
  12. 3/8 git-submodule.sh: improve parsing of short optionsRoy Eldar, Dec 9, 2024
  13. 4/8 git-submodule.sh: get rid of isnumberRoy Eldar, Dec 9, 2024
  14. 5/8 git-submodule.sh: get rid of unused variableRoy Eldar, Dec 9, 2024
  15. 6/8 git-submodule.sh: add some commentsRoy Eldar, Dec 9, 2024
  16. 7/8 git-submodule.sh: improve variables readabilityRoy Eldar, Dec 9, 2024
  17. 8/8 git-submodule.sh: rename some variablesRoy Eldar, Dec 9, 2024
  18. Junio C HamanoDec 9, 2024
  19. Junio C HamanoDec 10, 2024
  20. Roy EDec 10, 2024
  21. Junio C HamanoDec 11, 2024
  22. Roy EDec 11, 2024
  23. Junio C HamanoDec 11, 2024
  24. 0/7 git-submodule.sh: improve parsing of optionsRoy Eldar, Dec 10, 2024
  25. 1/7 git-submodule.sh: improve parsing of some long optionsRoy Eldar, Dec 10, 2024
  26. 2/7 git-submodule.sh: improve parsing of short optionsRoy Eldar, Dec 10, 2024
  27. 3/7 git-submodule.sh: get rid of isnumberRoy Eldar, Dec 10, 2024
  28. 4/7 git-submodule.sh: get rid of unused variableRoy Eldar, Dec 10, 2024
  29. 5/7 git-submodule.sh: add some commentsRoy Eldar, Dec 10, 2024
  30. 6/7 git-submodule.sh: improve variables readabilityRoy Eldar, Dec 10, 2024
  31. Junio C HamanoDec 11, 2024
  32. Roy EDec 11, 2024
  33. Đoàn Trần Công DanhDec 11, 2024
  34. Junio C HamanoDec 11, 2024
  35. 7/7 git-submodule.sh: rename some variablesRoy Eldar, Dec 10, 2024
  36. 0/7 git-submodule.sh: improve parsing of optionsRoy Eldar, Dec 11, 2024
  37. 1/7 git-submodule.sh: improve parsing of some long optionsRoy Eldar, Dec 11, 2024
  38. 2/7 git-submodule.sh: improve parsing of short optionsRoy Eldar, Dec 11, 2024
  39. 3/7 git-submodule.sh: get rid of isnumberRoy Eldar, Dec 11, 2024
  40. 4/7 git-submodule.sh: get rid of unused variableRoy Eldar, Dec 11, 2024
  41. 5/7 git-submodule.sh: add some commentsRoy Eldar, Dec 11, 2024
  42. 6/7 git-submodule.sh: improve variables readabilityRoy Eldar, Dec 11, 2024
  43. 7/7 git-submodule.sh: rename some variablesRoy Eldar, Dec 11, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.