Re: [PATCH] git-svn testsuite: use standard configuration for Subversion tools

From: Eygene Ryabinkin <rea-git@codelabs.ru>
Date: May 1, 2009, 19:10 UTC
Message-ID: <Z0zFdWIzyQzuBQjCf+Jk/nJtvIw@BjOYljNjUB0FD+/Fw7pzaXMw/Hc>
In-Reply-To: <7vfxfowugm.fsf@gitster.siamese.dyndns.org>

Junio, good day.

Fri, May 01, 2009 at 11:26:17AM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> Eygene Ryabinkin <rea-git@codelabs.ru> writes:
> 
> > @@ -54,6 +56,20 @@ poke() {
> >  	test-chmtime +1 "$1"
> >  }
> >  
> > +# We need this, because we should pass empty configuration directory to
> > +# the 'svn commit' to avoid automated property changes and other stuff
> > +# that could be set from user's configuration files in ~/.subversion.
> > +svn_cmd () {
> > +	local cmd
> 
> Does this work without your /bin/sh being bash?

Yes.

Naturally speaking, my /bin/sh isn't bash, but I had substituted it with the binary of bash 4.0.10(2) and it works. Moreover, I had just run t/t9100-*.sh on the RHEL 4.x -- works too.

What are your concerns, 'local'?

-- 
Eygene