Re: [PATCH] git-svn testsuite: use standard configuration for Subversion tools

From: Eygene Ryabinkin <rea-git@codelabs.ru>
Date: May 2, 2009, 10:36 UTC
Message-ID: <GzXVCxlG1vigUEGxhNBLVXNYljM@AnOk+mYbmYVORDu5SWQWxomMUcc>
In-Reply-To: <7viqkkv43t.fsf@gitster.siamese.dyndns.org>

Junio,

Fri, May 01, 2009 at 03:40:54PM -0700, Junio C Hamano wrote:

Show 5 quoted lines

> Eygene Ryabinkin <rea-git@codelabs.ru> writes:
> 
> > What are your concerns, 'local'?
> 
> Exactly.

It exists in Bash and in *BSD /bin/sh. It does not exist in Korn shell (at least, I am failing to find one). I can just remove 'local' from the function, since it plays no big role, but generally I don't like to pollute parent namespace by local variables. Certainly, if 'local' will break some known shell -- I'll refrain from using it in this script.

Do you know an example of shell that is used by Git (thus being /bin/sh in the system) and that lacks 'local' builtin?

Thanks!

-- 
Eygene