git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] rev-list: disable commit graph with --verify-objects

From
Taylor Blau <me@ttaylorr.com>
Date
Sep 6, 2022, 21:20 UTC
Message-ID
<Yxe5qwO/GzsEXMjb@nand.local>
In-Reply-To
<Yxe1422xPYoMNlkG@coredump.intra.peff.net>
On Tue, Sep 06, 2022 at 05:04:35PM -0400, Jeff King wrote:
> So it seems like the safest thing is to just disable the commit graph
> for the whole process when we see the --verify-objects option. We can do
> that either in builtin/rev-list.c, where we use the option, or in
> revision.c, where we parse it. There are some subtleties:
Agreed that putting it in the rev-list code makes sense.

I was wondering whether disabling the commit graph would survive a `raw_object_store_clear()` or `close_commit_graph()`. But it does, since we're not actually touching the `commit_graph` pointer itself, but a second variable `commit_graph_disabled`, which isn't ever set back to 0.

Thanks, Taylor

Previous: Jeff KingNext: Junio C Hamano
Message 5 of 7 in “bug with rev-list --verify-objects and commit-graph”
  1. 0/2 bug with rev-list --verify-objects and commit-graphJeff King, Sep 6, 2022
  2. 1/2 lookup_commit_in_graph(): use prepare_commit_graph() to check for graphJeff King, Sep 6, 2022
  3. Taylor BlauSep 6, 2022
  4. 2/2 rev-list: disable commit graph with --verify-objectsJeff King, Sep 6, 2022
  5. Taylor BlauSep 6, 2022
  6. Junio C HamanoSep 7, 2022
  7. Taylor BlauSep 6, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.