git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] bug with rev-list --verify-objects and commit-graph

From
Jeff King <peff@peff.net>
Date
Sep 6, 2022, 20:58 UTC
Message-ID
<Yxe0k++LA/UfFLF/@coredump.intra.peff.net>

While looking at something unrelated, I noticed that "git rev-list --verify-objects" will not actually notice corruptions of commits that are found in a commit graph. This fixes it.

The first one is a cleanup that is not strictly related, but is needed for the tests in the second to work reliably (and is a good idea anyway).

The second is the fix. I don't think it's super-important, as we do not use --verify-objects for anything, since d21c463d55 (fetch/receive: remove over-pessimistic connectivity check, 2012-03-15). And it's not even documented, so perhaps we should just consider getting rid of it. But in the meantime, it was easy enough to correct.

  [1/2]: lookup_commit_in_graph(): use prepare_commit_graph() to check for graph
  [2/2]: rev-list: disable commit graph with --verify-objects
 commit-graph.c  |  2 +-
 revision.c      |  1 +
 t/t1450-fsck.sh | 28 ++++++++++++++++++++++++++++
 3 files changed, 30 insertions(+), 1 deletion(-)
-Peff
Next: Jeff King
Message 1 of 7 in “bug with rev-list --verify-objects and commit-graph”
  1. 0/2 bug with rev-list --verify-objects and commit-graphJeff King, Sep 6, 2022
  2. 1/2 lookup_commit_in_graph(): use prepare_commit_graph() to check for graphJeff King, Sep 6, 2022
  3. Taylor BlauSep 6, 2022
  4. 2/2 rev-list: disable commit graph with --verify-objectsJeff King, Sep 6, 2022
  5. Taylor BlauSep 6, 2022
  6. Junio C HamanoSep 7, 2022
  7. Taylor BlauSep 6, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.