Re: "git symbolic-ref" doesn't do a very good job

From: Jeff King <peff@peff.net>
Date: Aug 2, 2022, 00:46 UTC
Message-ID: <Yuhz0VAX77qv4P5Z@coredump.intra.peff.net>
In-Reply-To: <xmqqfsifyetv.fsf@gitster.g>

On Mon, Aug 01, 2022 at 11:54:36AM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> > +test_expect_success 'symbolic-ref allows top-level target for non-HEAD' '
> > +	git symbolic-ref refs/heads/top-level FETCH_HEAD &&
> > +	git update-ref FETCH_HEAD HEAD &&
> > +	test_cmp_rev top-level HEAD
> > +'
> >  test_done
> 
> Strange, but OK.

I'd be OK to drop this if you hate it too much, btw. Mostly I wanted to make sure that the various iterations behaved as I expected. But there is a test in t3200 (the one Linus found earlier) that incidentally does check that something like this works.

-Peff