git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: "git symbolic-ref" doesn't do a very good job

From
Jeff King <peff@peff.net>
Date
Aug 1, 2022, 17:46 UTC
Message-ID
<YugRYN6sbP+RpxlJ@coredump.intra.peff.net>
In-Reply-To
<YugQqp4oN26OFOpt@coredump.intra.peff.net>
On Mon, Aug 01, 2022 at 01:43:06PM -0400, Jeff King wrote:
Show 5 quoted lines
>   2. Your patch, but with ALLOW_ONELEVEL. This fixes nonsense like
>      "foo..bar", but doesn't break "FETCH_HEAD". Requires fixing t4202's
>      ".lock" example. Replaces the HEAD starts_with("refs/") check.
> 
>   3. Your patch as-is. Same as (2), but also breaks FETCH_HEAD.

Er, sorry, the starts_with() thing is the other way around. It is redundant with your patch, but necessary to keep it for (2). Luckily t1401 catches the problem if you dare to try it. ;)

-Peff
Previous: Jeff KingNext: Jeff King
Message 8 of 17 in “"git symbolic-ref" doesn't do a very good job”
  1. Linus TorvaldsJul 30, 2022
  2. Linus TorvaldsJul 30, 2022
  3. Junio C HamanoJul 30, 2022
  4. Jeff KingJul 31, 2022
  5. Jeff KingJul 31, 2022
  6. Linus TorvaldsJul 31, 2022
  7. Jeff KingAug 1, 2022
  8. Jeff KingAug 1, 2022
  9. Jeff KingAug 1, 2022
  10. Junio C HamanoAug 1, 2022
  11. Jeff KingAug 2, 2022
  12. Junio C HamanoAug 2, 2022
  13. Linus TorvaldsAug 1, 2022
  14. Junio C HamanoJul 31, 2022
  15. Jeff KingAug 1, 2022
  16. Linus TorvaldsAug 1, 2022
  17. Jeff KingAug 1, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.