git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] bisect: status improvements when bisect is not fully fleshed out

From
Chris Down <chris@chrisdown.name>
Date
May 7, 2022, 10:58 UTC
Message-ID
<YnZQvuyeu/WZLhXH@chrisdown.name>
In-Reply-To
<cover.1651796862.git.chris@chrisdown.name>

Thanks Junio and Taylor for reviewing. I have the following action items for v3:

# [1/3] bisect: lowercase "Bisect:" to "bisect:" prior to wider use
- New patch
# [2/3] bisect: output state before we are ready to compute bisection 
- Fix multiline comment style in bisect.h
- Zero-initialise bisect_state directly, don't use memset()
- Pass the bisect state struct as an argument into bisect_print_status
- Change from "status:" to "bisecting:"
# [3/3] bisect: output bisect setup status in bisect log
- Use strbuf in bisect_log_printf
- Change `git bisect log' use an output file in tests instead of piping
I'll wait a bit to see if there's any further feedback and then will send v3.
Thanks!
Previous: Taylor BlauNext: Junio C Hamano
Message 17 of 19 in “bisect: status improvements when bisect is not fully fleshed out”
  1. 0/2 bisect: status improvements when bisect is not fully fleshed outChris Down, May 6, 2022
  2. 1/2 bisect: output state before we are ready to compute bisectionChris Down, May 6, 2022
  3. Taylor BlauMay 6, 2022
  4. Chris DownMay 6, 2022
  5. Junio C HamanoMay 6, 2022
  6. Junio C HamanoMay 6, 2022
  7. 2/2 bisect: output bisect setup status in bisect logChris Down, May 6, 2022
  8. Taylor BlauMay 6, 2022
  9. Chris DownMay 6, 2022
  10. Taylor BlauMay 9, 2022
  11. Junio C HamanoMay 6, 2022
  12. Junio C HamanoMay 6, 2022
  13. Junio C HamanoMay 6, 2022
  14. Taylor BlauMay 9, 2022
  15. Junio C HamanoMay 9, 2022
  16. Taylor BlauMay 9, 2022
  17. Chris DownMay 7, 2022
  18. Junio C HamanoMay 7, 2022
  19. Chris DownMay 7, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.