Re: [PATCH v2 0/2] bisect: status improvements when bisect is not fully fleshed out
- From
Chris Down <chris@chrisdown.name>
- Date
- May 7, 2022, 10:58 UTC
- Message-ID
- <YnZQvuyeu/WZLhXH@chrisdown.name>
- In-Reply-To
- <cover.1651796862.git.chris@chrisdown.name>
Thanks Junio and Taylor for reviewing. I have the following action items for v3:
# [1/3] bisect: lowercase "Bisect:" to "bisect:" prior to wider use
- New patch
# [2/3] bisect: output state before we are ready to compute bisection
- Fix multiline comment style in bisect.h - Zero-initialise bisect_state directly, don't use memset() - Pass the bisect state struct as an argument into bisect_print_status - Change from "status:" to "bisecting:"
# [3/3] bisect: output bisect setup status in bisect log
- Use strbuf in bisect_log_printf - Change `git bisect log' use an output file in tests instead of piping
I'll wait a bit to see if there's any further feedback and then will send v3.
Thanks!