Re: [PATCH v8 0/3] teach submodules to know they're submodules

From: Emily Shaffer <emilyshaffer@google.com>
Date: Mar 8, 2022, 18:54 UTC
Message-ID: <YiemguagkDdoUkp2@google.com>
In-Reply-To: <xmqq7d9ewerw.fsf@gitster.g>

On Mon, Feb 28, 2022 at 07:08:35PM -0800, Junio C Hamano wrote:

Show 21 quoted lines

> 
> Emily Shaffer <emilyshaffer@google.com> writes:
> 
> > One thing I'm not sure about: in the tests, I check whether the config
> > is set, but not what the boolean value of it is. Is there a better way
> > to do that?
> 
> Are you looking for value normalization during both setting and
> retrieving, i.e.
> 
> 	$ git config vari.able 0 ;# or "no" or "off"
> 	$ git config --type=bool vari.abble
> 	false
> 	$ git config vari.able 1 ;# or "yes" or "on"
> 	$ git config --type=bool vari.abble
> 	true
> 
> 	$ git config --type=bool vari.able yes ;# or "1" or "on"
> 	$ git config vari.able
> 	true
>

Ah, thanks! This helps. But that means I still need to check the return value, and associate "didn't find anything" (1) with the default as documented in Docs/config/submodule.txt, right?

Either way, this is useful. Thanks!

 - Emily