Re: [PATCH v3 1/3] SubmittingPatches: write problem statement in the log in the present tense
- From
Emily Shaffer <emilyshaffer@google.com>
- Date
- Mar 4, 2022, 23:41 UTC
- Message-ID
- <YiKjtcHSBXWky7Ze@google.com>
- In-Reply-To
- <xmqqzgm65zvy.fsf@gitster.g>
On Thu, Mar 03, 2022 at 04:23:45PM -0800, Junio C Hamano wrote:
Show 13 quoted lines
> > Emily Shaffer <emilyshaffer@google.com> writes: > > > As for the norm itself, I think it is a good one, and I've seen it > > pointed out in code reviews frequently. Thanks. > > > > Reviewed-by: Emily Shaffer <emilyshaffer@google.com> > > Thanks. > > Was this meant to be sent long after the topic was merged to > 'master' at 83760938 (Merge branch 'jc/doc-log-messages', > 2022-02-11)?
As mentioned in https://lore.kernel.org/git/YiFZicz69mDyFzXB%40google.com - no, it wasn't. In fact, in conversation at $dayjob someone said "whatever happened to Junio planning to write updates to SubmittingPatches?" and someone else said "it didn't really get any review" - so I said "okay, I will do review" instead of checking whether you merged anyway. So mostly useless noise :)
- Emily