git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] l10n: README: call more attention to plural strings

From
Josh Steadmon <steadmon@google.com>
Date
Dec 21, 2021, 19:01 UTC
Message-ID
<YcIkdXcLgzUk3+Jc@google.com>
In-Reply-To
<CANYiYbF31o-sQYU-OjJk=pQR5RHM0k7jqmEhiKGLeO3Suu1khQ@mail.gmail.com>
On 2021.12.16 09:10, Jiang Xin wrote:
Show 35 quoted lines
> On Tue, Dec 14, 2021 at 6:02 AM Josh Steadmon <steadmon@google.com> wrote:
> >
> > On 2021.12.13 13:56, Junio C Hamano wrote:
> > > Josh Steadmon <steadmon@google.com> writes:
> > >
> > > > In po/README.md, we point core developers to gettext's "Preparing
> > > > Strings" documentation for advice on marking strings for translation.
> > > > However, this doc doesn't really discuss the issues around plural form
> > > > translation, which can make it seem that nothing special needs to be
> > > > done in this case.
> > > >
> > > > Add a specific callout here about marking plural-form strings so that
> > > > the advice later on in the README is not overlooked.
> > > >
> > > > Signed-off-by: Josh Steadmon <steadmon@google.com>
> > > > ---
> > > >  po/README.md | 5 ++++-
> > > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/po/README.md b/po/README.md
> > > > index dcd8436c25..fd1e024dd3 100644
> > > > --- a/po/README.md
> > > > +++ b/po/README.md
> > > > @@ -219,7 +219,10 @@ General advice:
> > > >    they're part of Git's API.
> > > >
> > > >  - Adjust the strings so that they're easy to translate. Most of the
> > > > -  advice in `info '(gettext)Preparing Strings'` applies here.
> > > > +  advice in `info '(gettext)Preparing Strings'` applies here. Strings
> > > > +  referencing numbers of items may need to be split into singular and
> > > > +  plural forms; see the Q\_() wrapper in the C sub-section below for an
> > > > +  example.
> 
> Wouldn't it be better if we add a new rule ("Strings ... an example.")
> after this one?
Fixed in V2, thanks!
Previous: Jiang XinNext: Josh Steadmon
Message 6 of 9 in “l10n: README: call more attention to plural strings”
  1. l10n: README: call more attention to plural stringsJosh Steadmon, Dec 13, 2021
  2. Junio C HamanoDec 13, 2021
  3. Josh SteadmonDec 13, 2021
  4. Junio C HamanoDec 13, 2021
  5. Jiang XinDec 16, 2021
  6. Josh SteadmonDec 21, 2021
  7. l10n: README: call more attention to plural stringsJosh Steadmon, Dec 21, 2021
  8. Junio C HamanoDec 21, 2021
  9. Jiang XinDec 22, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.