Re: [PATCH 0/3] support `--oid-only` in `ls-tree`

From: Jeff King <peff@peff.net>
Date: Nov 15, 2021, 19:23 UTC
Message-ID: <YZKzpv+n6bHJ2WOs@coredump.intra.peff.net>
In-Reply-To: <20211115115153.48307-1-dyroneteng@gmail.com>

On Mon, Nov 15, 2021 at 07:51:50PM +0800, Teng Long wrote:

Show 11 quoted lines

> Sometimes, we only want to get the objects from output of `ls-tree`
> and commands like `sed` or `cut` is usually used to intercept the
> origin output to achieve this purpose in practical.
> 
> The patch contains three commits
> 
>     1. Implementation of the option.
>     2. Add new tests in "t3104".
>     3. Documentation modifications.
> 
> I'm appreciate if someone help to review the patch.

This seems like a good feature to have. I think it would make sense to squash the three patches into a single one. The documentation and test patches do not stand on their own, which is why there was nothing useful to say in their commit messages.

The implementation looks generally sensible (modulo the comments already given). I was surprised that there was not an existing ls-tree script that these would fit into. But there really isn't; t3101 covers --name-only and other output, but is really focused on the pathnames (though I think it would be OK to refactor it to cover output more generally).

-Peff