Re: [PATCH v2 1/1] ls-tree.c: support `--oid-only` option for "git-ls-tree"

From

Teng Long <dyroneteng@gmail.com>

Date

Nov 22, 2021, 07:45 UTC

Message-ID

<20211122074538.87255-1-dyroneteng@gmail.com>

In-Reply-To

<211119.86wnl42ri2.gmgdl@evledraar.gmail.com>

On Fri, 19 Nov 2021 14:30:52 +0100, Ævar Arnfjörð Bjarmason wrote

> Please don't add the Reviewed-by headers yourself, either Junio
> accumulates them, or if someone explicitly mentions that you can add it
> with their name it's OK.

> Better: "Cannot be combined with OPT."
> Better: "Cannot be combined with OPT or OPT2."
> ...
> Better to preserve the wrapping here, to stay within 79 columns.

Will apply.

> Just use:
>
>     test_commit A &&
>     test_commit B
>
> etc?
> ...
> Stray echo? Unclear why this test setup is so complex, shouldn't this just be (continued from above):
>
>     mkdir -p C &&
>     test_commit C/D.txt

> To test nested dirs?

Will apply.

> just cut -f1 instead of awk? Also don't put "git" on the LHS of a pipe,
> it might hide segfaults. Also applies to the below.
>

Thank you.