Re: [PATCH v3 0/9] repack: introduce `--write-midx`

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 1, 2021, 22:40 UTC
Message-ID: <YVeOcL7/kPxt5XVu@nand.local>
In-Reply-To: <20211001200135.215855-1-jonathantanmy@google.com>

On Fri, Oct 01, 2021 at 01:01:35PM -0700, Jonathan Tan wrote:

Show 8 quoted lines

> > Here is another small reroll of my series to implement the final component of
> > multi-pack reachability bitamps, which is to be able to write them from `git
> > repack`.
>
> I see that all my comments up to patch 6 (of v2) have been addressed.
> There is one outstanding one involving a potentially uninitialized
> variable [1] from patch 8 (of v2) that you (Taylor) might have missed
> since I sent it after I reviewed the first 6.

Thanks! I must have missed your review of v2 when I sent v3 (indeed, my reroll came 5 days after you sent [1], so I missed it).

I sent a replacement patch here:

    https://lore.kernel.org/git/YVeN0mXqYvTHtNB+@nand.local/

which Junio can take instead of [v3 8/8]. But I'm happy to reroll the whole series, too, whatever is easier.

> Reviewed-by: Jonathan Tan <jonathantanmy@google.com> (conditional on
> that being resolved)

Thanks again :-).

> [1] https://lore.kernel.org/git/20210924182247.2922561-1-jonathantanmy@google.com/

Thanks, Taylor