Re: [PATCH 8/8] builtin/repack.c: pass `--refs-snapshot` when writing bitmaps

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 15, 2021, 04:31 UTC
Message-ID: <YUF3NXcjo2dWtPOR@nand.local>
In-Reply-To: <87a6keoglz.fsf@evledraar.gmail.com>

On Wed, Sep 15, 2021 at 01:56:00AM +0200, Ævar Arnfjörð Bjarmason wrote:

> The suggestion I had offhand was just meant as an offhand "interesting,
> maybe easier like...", i.e. if you found it easier to split on \t, or
> check the hash size in the loop or whatever.

:-). You did say "Just an idea", but I treated your suggestion as if you were concerned about being able to extend the format in the future.

> I agree that this doesn't matter and should just be left to whatever
> you've got a taste for, thanks. This thread became more of a digression
> than I thought...

I think that all of the discussion was reasonable if I understood your original opinion more clearly ;). It may help (me, at least) to say more explicitly, "This may be easier like [...] but I don't have any concerns about functionality" or similar.

Thanks, Taylor