git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Oct 2021, #02; Wed, 6)

From
Taylor Blau <me@ttaylorr.com>
Date
Oct 7, 2021, 04:07 UTC
Message-ID
<YV5yi+AejPGO9qOi@nand.local>
In-Reply-To
<YV5dmkkuCqAY2qqG@coredump.intra.peff.net>
On Wed, Oct 06, 2021 at 10:38:18PM -0400, Jeff King wrote:
Show 5 quoted lines
> The reason for that is that I didn't find it by inspection; I've started
> running my personal builds through coverity. It wasn't too bad to set up
> with a GitHub Action, like so:
>
> [...]

It looks like this would never cause the build to fail, but is merely responsible for sending any warnings off to Coverity's UI?

Show 5 quoted lines
> Is there interest in having something like this in the main repo? We'd
> need to tweak some values:
>
>   - we have to send the project name (here peff/git); we can presumably
>     get this on the fly from the Actions environment
Yes; searching through [1] it looks like that is called $GITHUB_REPOSITORY.
[1]: https://docs.github.com/en/actions/learn-github-actions/environment-variables
Show 8 quoted lines
>   - any repo which wants to use this has to set up the secret token
>     (COVERITY_SCAN_TOKEN here). That involves creating a coverity
>     account, and then setting the token in the GitHub web interface.
>     Presumably we'd just bail immediately if that token isn't set, so
>     forks aside from git/git would have to enable it independently.
>
>   - likewise it needs the email address for the coverity account. That
>     could probably be set in the environment, too.
These both seem reasonable to me, too.
Show 6 quoted lines
> There are tons of existing warnings, many of which are false positives.
> But it keeps track of which problems are new, and emails out a summary
> of only the new ones (which is how I saw the leak here, which just hit
> next). I don't care all that much about leaks here (we have other
> techniques for finding them), but when Stefan used to do regular
> coverity builds in the past, it routinely found useful errors.

I'm generally pessimistic about tools like Coverity, but I share your experience that Coverity warnings are actually pretty high quality. Or at least they have a high enough signal-to-noise ratio that it makes them worth looking through.

So I would be happy to have forks of GitHub have fewer barriers to use this tool.

Thanks, Taylor

Previous: Jeff KingNext: Jeff King
Message 5 of 24 in “What's cooking in git.git (Oct 2021, #02; Wed, 6)”
  1. Junio C HamanoOct 7, 2021
  2. ab/make-sparse-for-realÆvar Arnfjörð Bjarmason, Oct 7, 2021
  3. Jeff KingOct 7, 2021
  4. Jeff KingOct 7, 2021
  5. Taylor BlauOct 7, 2021
  6. Jeff KingOct 8, 2021
  7. Johannes SchindelinOct 8, 2021
  8. Jeff KingOct 8, 2021
  9. Johannes SchindelinOct 20, 2021
  10. Taylor BlauOct 20, 2021
  11. Junio C HamanoOct 20, 2021
  12. Jeff KingOct 20, 2021
  13. Coverity, was Re: What's cooking in git.git (Oct 2021, #02; Wed, 6)Johannes Schindelin, Aug 16, 2022
  14. Jeff KingAug 17, 2022
  15. Johannes SchindelinAug 19, 2022
  16. Ævar Arnfjörð BjarmasonOct 7, 2021
  17. Jeff KingOct 8, 2021
  18. Junio C HamanoOct 8, 2021
  19. Jeff KingOct 8, 2021
  20. Junio C HamanoOct 8, 2021
  21. Ævar Arnfjörð BjarmasonOct 7, 2021
  22. Taylor BlauOct 7, 2021
  23. Taylor BlauOct 7, 2021
  24. Junio C HamanoOct 7, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.