git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Coverity, was Re: What's cooking in git.git (Oct 2021, #02; Wed, 6)

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 16, 2022, 09:05 UTC
Message-ID
<2n33pn8n-7529-443q-rq7n-q12nrqrn8p27@tzk.qr>
In-Reply-To
<YXBALFsf305U8mJs@coredump.intra.peff.net>
Hi Peff & Taylor,
On Wed, 20 Oct 2021, Jeff King wrote:
Show 34 quoted lines
> On Wed, Oct 20, 2021 at 02:27:30PM +0200, Johannes Schindelin wrote:
>
> > On Fri, 8 Oct 2021, Jeff King wrote:
> >
> > > On Fri, Oct 08, 2021 at 09:51:33AM +0200, Johannes Schindelin wrote:
> > >
> > > > FWIW I have set up an Azure Pipeline to keep Git for Windows'
> > > > `main` branch covered by Coverity:
> > > >
> > > > https://dev.azure.com/git-for-windows/git/_build?definitionId=35
> > > >
> > > > It essentially calls into this scripted code:
> > > > https://github.com/git-for-windows/build-extra/blob/4676f286a1ec830a5038b32400808a353dc6c48d/please.sh#L1820-L1915
> > >
> > > Do you have any objection to adding something like the Action I
> > > showed eariler? It would do nothing in git-for-windows/git unless
> > > you set up the right environment, so there shouldn't be any
> > > downside.
> >
> > No objection. I'd just ask to use `${{github.repository}}` instead of
> > hard-coding `peff/git`, and to really not run the workflow unless
> > configured. So something like this:
>
> Yep, those were directions I was planning to take it.
>
> > I am very much in favor of having this in git/git. Do you want to provide
> > the commit message, or do you want me to shepher this?
>
> I'd be just as happy if you did (I hadn't even looked at it since my
> earlier email).
>
> It sounds like Taylor is volunteering to set up the Coverity side for
> git.git, and I can help him with getting those COVERITY_* variables into
> the GitHub environment.

Given the challenges with Coverity (false positives, lack of support on Synopsys' side, severely limited access to the reports), and given the renewed efforts by OSTIF that focus not on Coverity but on CodeQL, I am in favor of abandoning the idea to integrate Coverity in our GitHub workflow.

Regarding CodeQL, I am still uncertain what level of integration we will end up with, and the contacts I am working with are currently all on vacation, but I am confident that we will have an easier time going forward with static analysis using CodeQL instead of Coverity.

Ciao, Dscho

Previous: Jeff KingNext: Jeff King
Message 13 of 24 in “What's cooking in git.git (Oct 2021, #02; Wed, 6)”
  1. Junio C HamanoOct 7, 2021
  2. ab/make-sparse-for-realÆvar Arnfjörð Bjarmason, Oct 7, 2021
  3. Jeff KingOct 7, 2021
  4. Jeff KingOct 7, 2021
  5. Taylor BlauOct 7, 2021
  6. Jeff KingOct 8, 2021
  7. Johannes SchindelinOct 8, 2021
  8. Jeff KingOct 8, 2021
  9. Johannes SchindelinOct 20, 2021
  10. Taylor BlauOct 20, 2021
  11. Junio C HamanoOct 20, 2021
  12. Jeff KingOct 20, 2021
  13. Coverity, was Re: What's cooking in git.git (Oct 2021, #02; Wed, 6)Johannes Schindelin, Aug 16, 2022
  14. Jeff KingAug 17, 2022
  15. Johannes SchindelinAug 19, 2022
  16. Ævar Arnfjörð BjarmasonOct 7, 2021
  17. Jeff KingOct 8, 2021
  18. Junio C HamanoOct 8, 2021
  19. Jeff KingOct 8, 2021
  20. Junio C HamanoOct 8, 2021
  21. Ævar Arnfjörð BjarmasonOct 7, 2021
  22. Taylor BlauOct 7, 2021
  23. Taylor BlauOct 7, 2021
  24. Junio C HamanoOct 7, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.