git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t/perf: do not run tests in user's $SHELL

From
Jeff King <peff@peff.net>
Date
Oct 8, 2021, 05:41 UTC
Message-ID
<YV/aD6NKdG+w9ghr@coredump.intra.peff.net>
In-Reply-To
<20211008053450.wjttkhsbbsnuwwpt@gmail.com>
On Fri, Oct 08, 2021 at 07:34:50AM +0200, Johannes Altmanninger wrote:
Show 8 quoted lines
> On Thu, Oct 07, 2021 at 11:07:43PM -0400, Jeff King wrote:
> 
> > I wondered if we would always have TEST_SHELL_PATH set, but we should:
> > it is put unconditionally into GIT-BUILD-OPTIONS, and we will always
> > load that via test-lib.sh, even if the test is run outside of "make".
> 
> Yeah I was gonna add this to the commit message but didn't because it's fairly
> easy to check. Probably still better to include it. I can resend if that helps.

I think it's probably fine as-is. Mostly I was talking to myself out loud to let people follow along my review process. :)

-Peff
Previous: Johannes AltmanningerNext: brian m. carlson
Message 6 of 7 in “perf: fix test_export with SHELL=zsh”
  1. perf: fix test_export with SHELL=zshRené Scharfe, Oct 2, 2021
  2. Johannes AltmanningerOct 2, 2021
  3. t/perf: do not run tests in user's $SHELLJohannes Altmanninger, Oct 7, 2021
  4. Jeff KingOct 8, 2021
  5. Johannes AltmanningerOct 8, 2021
  6. Jeff KingOct 8, 2021
  7. brian m. carlsonOct 2, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.