From: Jeff King <peff@peff.net>
Date: Fri, 08 Oct 2021 05:41:35 GMT
Subject: Re: [PATCH] t/perf: do not run tests in user's $SHELL
Message-ID: <YV/aD6NKdG+w9ghr@coredump.intra.peff.net>
In-Reply-To: <20211008053450.wjttkhsbbsnuwwpt@gmail.com>

On Fri, Oct 08, 2021 at 07:34:50AM +0200, Johannes Altmanninger wrote:

> On Thu, Oct 07, 2021 at 11:07:43PM -0400, Jeff King wrote:
> 
> > I wondered if we would always have TEST_SHELL_PATH set, but we should:
> > it is put unconditionally into GIT-BUILD-OPTIONS, and we will always
> > load that via test-lib.sh, even if the test is run outside of "make".
> 
> Yeah I was gonna add this to the commit message but didn't because it's fairly
> easy to check. Probably still better to include it. I can resend if that helps.

I think it's probably fine as-is. Mostly I was talking to myself out
loud to let people follow along my review process. :)

-Peff