Re: [PATCH v2 6/8] progress.c: add temporary variable from progress struct

From: Emily Shaffer <emilyshaffer@google.com>
Date: Oct 8, 2021, 04:02 UTC
Message-ID: <YV/C3SBBDWiZCAq1@google.com>
In-Reply-To: <patch-v2-6.8-d4e9ff1de73-20210920T225701Z-avarab@gmail.com>

On Tue, Sep 21, 2021 at 01:09:27AM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 7 quoted lines

> 
> Add a temporary "progress" variable for the dereferenced p_progress
> pointer to a "struct progress *". Before 98a13647408 (trace2: log
> progress time and throughput, 2020-05-12) we didn't dereference
> "p_progress" in this function, now that we do it's easier to read the
> code if we work with a "progress" struct pointer like everywhere else,
> instead of a pointer to a pointer.

Thanks, this looks much nicer :)

> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

Reviewed-by: Emily Shaffer <emilyshaffer@google.com>

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.