Re: [PATCH 1/7] progress: introduce GIT_TEST_CHECK_PROGRESS to verify progress counters
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jun 21, 2021, 07:09 UTC
- Message-ID
- <87y2b33d7y.fsf@evledraar.gmail.com>
- In-Reply-To
- <20210620200303.2328957-2-szeder.dev@gmail.com>
On Sun, Jun 20 2021, SZEDER Gábor wrote:
Show 10 quoted lines
> @@ -252,7 +255,11 @@ void display_progress(struct progress *progress, uint64_t n)
> static struct progress *start_progress_delay(const char *title, uint64_t total,
> unsigned delay, unsigned sparse)
> {
> - struct progress *progress = xmalloc(sizeof(*progress));
> + struct progress *progress;
> +
> + test_check_progress = git_env_bool("GIT_TEST_CHECK_PROGRESS", 0);
> +
> + progress = xmalloc(sizeof(*progress));Is this simply an unrelated cleanup/refactoring? I don't see how this re-arrangement is needed for adding the git_env_bool() call.