Re: [PATCH v2 0/2] Makefile: "pedantic" fallout on .depend and "compdb"

From: Jeff King <peff@peff.net>
Date: Sep 23, 2021, 17:38 UTC
Message-ID: <YUy7k3Yo0YeiFk6u@coredump.intra.peff.net>
In-Reply-To: <cover-v2-0.2-00000000000-20210922T220532Z-avarab@gmail.com>

On Thu, Sep 23, 2021 at 12:08:00AM +0200, Ævar Arnfjörð Bjarmason wrote:

> In this v2 I just added an unconditional -Wno-pedantic and omitted the
> change to spew error on STDERR. This more narrowly fixes the immediate
> issue and doesn't get into whether we should use /dev/null or whatever
> as input.

FWIW, this seems perfectly fine to me. Removing $(ALL_CFLAGS) entirely seems OK to me, too, but this is a smaller change, and would help any cases where those flags are somehow important to getting the compiler to function at all.

It's possible some compiler _does_ understand -MF, etc, but not -Wno-pedantic, but that seems unlikely to me. (And of course there is always the fallback of setting COMPUTE_HEADER_DEPENDENCIES yourself on such a system; this is really just about doing the right thing on most people's setups).

Another related alternative is to use -Wno-error, which would fix the pedantic problem, along with any other warnings a compiler chooses to bring up for an empty file. I don't have a strong opinion on one versus the other.

-Peff