Re: [PATCH v2 0/7] pack-bitmap: permute existing namehash values

From: Jeff King <peff@peff.net>
Date: Sep 16, 2021, 22:52 UTC
Message-ID: <YUPKnd3jekNR80i4@coredump.intra.peff.net>
In-Reply-To: <cover.1631657157.git.me@ttaylorr.com>

On Tue, Sep 14, 2021 at 06:05:59PM -0400, Taylor Blau wrote:

Show 6 quoted lines

> Here is a small-ish rerool of my series to carry forward values from an existing
> hash-cache when generating multi-pack reachability bitmaps.
> 
> Since last time, the performance tests in p5326 were cleaned up in order to
> produce timings for generating a pack when using a MIDX bitmap with the
> hash-cache extension.

I had seen most of these in prototype form before, but I hadn't yet carefully looked at your cleanups for upstream. I gave them all a careful read, and it all looks good to me.

I did have a few comments on patch 6 that I think are worth following up on. We can also do so on top if you prefer.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.