git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] compression: drop write-only core_compression_* variables

From
Jeff King <peff@peff.net>
Date
Sep 11, 2021, 14:15 UTC
Message-ID
<YTy6ELXWB2DdDLYN@coredump.intra.peff.net>
In-Reply-To
<6ed7da24-81d0-0b5e-dca3-664d2c773474@web.de>
On Sat, Sep 11, 2021 at 01:45:43PM +0200, René Scharfe wrote:
> Since 8de7eeb54b (compression: unify pack.compression configuration
> parsing, 2016-11-15) the variables core_compression_level and
> core_compression_seen are only set, but never read.  Remove them.
This makes sense, but it seemed weirdly familiar.
It looks like something similar was part of this series:
  https://lore.kernel.org/git/20210731024221.2113906-1-mathstuf@gmail.com/

which seems to have slipped through the cracks (and has several other cleanups). Maybe we can resurrect it (though I think your cleanup of the related "seen" variable here means we should take this in the meantime).

-Peff
Previous: René Scharfe
Message 2 of 2 in “compression: drop write-only core_compression_* variables”
  1. compression: drop write-only core_compression_* variablesRené Scharfe, Sep 11, 2021
  2. Jeff KingSep 11, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.