From: Jeff King <peff@peff.net>
Date: Sat, 11 Sep 2021 14:15:44 GMT
Subject: Re: [PATCH] compression: drop write-only core_compression_* variables
Message-ID: <YTy6ELXWB2DdDLYN@coredump.intra.peff.net>
In-Reply-To: <6ed7da24-81d0-0b5e-dca3-664d2c773474@web.de>

On Sat, Sep 11, 2021 at 01:45:43PM +0200, René Scharfe wrote:

> Since 8de7eeb54b (compression: unify pack.compression configuration
> parsing, 2016-11-15) the variables core_compression_level and
> core_compression_seen are only set, but never read.  Remove them.

This makes sense, but it seemed weirdly familiar.

It looks like something similar was part of this series:

  https://lore.kernel.org/git/20210731024221.2113906-1-mathstuf@gmail.com/

which seems to have slipped through the cracks (and has several other
cleanups). Maybe we can resurrect it (though I think your cleanup of the
related "seen" variable here means we should take this in the meantime).

-Peff