Re: [PATCH v2 3/4] difftool: use run_command() API in run_file_diff()

From: Jeff King <peff@peff.net>
Date: Sep 13, 2021, 19:27 UTC
Message-ID: <YT+mGUkQAG7eVZp0@coredump.intra.peff.net>
In-Reply-To: <87a6kg46xh.fsf@evledraar.gmail.com>

On Mon, Sep 13, 2021 at 09:13:43PM +0200, Ævar Arnfjörð Bjarmason wrote:

> Yes, I had something like that in the earlier round, but decided to try
> to keep the diff minimal, churn and all that. So it would be nice, but
> let's do it as some later cleanup if someone's interested.

OK, let's leave it for now, then.

Show 5 quoted lines

> Aside: I did most of that removal of "argv" from the child_process
> struct you suggested, it's in
> avar/run-command-use-less-argv-use-args-instead in my repo if you're
> curious / wanted to pick any of that up. I won't be submitting it any
> time soon for the reasons noted upthread.

Yeah, it's rather far-reaching, which is why I didn't do a mass-conversion when I introduced "args" in c460c0ecdc (run-command: store an optional argv_array, 2014-05-15). My plan was to clean up spots over time as we touched them, but of course that's quite a slow process.

Mostly I just didn't want to see any sites going the _other_ direction, as in your original version of the series. :)

I'm quite happy with what you ended up with here.

-Peff